On Sun, 2011-06-19 at 01:07 -0700, Johannes Berg wrote:
> On Sat, 2011-06-11 at 07:25 -0700, Wey-Yi Guy wrote:
>
> > +++ b/drivers/net/wireless/iwlwifi/iwl-testmode.h
> > @@ -167,6 +167,7 @@ enum iwl_tm_attr_t {
> > */
> > IWL_TM_ATTR_TRACE_ADDR,
> > IWL_TM_ATTR_TRACE_DATA,
> > + IWL_TM_ATTR_TRACE_SIZE,
> >
> > /* When IWL_TM_ATTR_COMMAND is IWL_TM_CMD_APP2DEV_FIXRATE_REQ,
> > * The mandatory fields are:
>
> I know that currently there are no applications, but I really think we
> need to be much more careful about this as it is quickly becoming ABI,
> so you can't just insert attributes in the middle.
>
point taken, I will continue work in this area and will try to see how
to address this issue in my following patches
Thanks
Wey
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
