On Sat, 2011-06-18 at 22:32 +0300, Arik Nemtsov wrote:
> Use the tx_frames_pending() driver callback to determine if Tx frames are
> pending for its internal queues. If so postpone the dynamic PS timeout
> to avoid interrupting Tx traffic.
>
> The commit e8306f989483e4b97a8b37dd268de6c8c6f35e75 enabled this
> behavior for drivers with IEEE80211_HW_PS_NULLFUNC_STACK. We enable this
> for all drivers supporting dynamic PS.
>
> This patch helps improve performance in noisy environments.
FWIW, I don't really consider myself maintaining the PS
implementation ;-) I don't understand it and think the code is way too
complex.
I'm still not convinced I like the drv_tx_frames_pending() thing, but
then again I don't really care much anyway about PS stuff.
johannes
> Signed-off-by: Arik Nemtsov <arik@xxxxxxxxxx>
> ---
> net/mac80211/mlme.c | 22 +++++++++++++---------
> 1 files changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index a41f234..3a1699b 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -758,19 +758,23 @@ void ieee80211_dynamic_ps_enable_work(struct work_struct *work)
> if (local->hw.conf.flags & IEEE80211_CONF_PS)
> return;
>
> + /* don't enter PS if dynamic PS is enabled and TX frames are pending */
> + if (local->hw.conf.dynamic_ps_timeout > 0 &&
> + !local->disable_dynamic_ps && drv_tx_frames_pending(local)) {
> + mod_timer(&local->dynamic_ps_timer, jiffies +
> + msecs_to_jiffies(
> + local->hw.conf.dynamic_ps_timeout));
> + return;
> + }
> +
> if ((local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) &&
> (!(ifmgd->flags & IEEE80211_STA_NULLFUNC_ACKED))) {
> netif_tx_stop_all_queues(sdata->dev);
>
> - if (drv_tx_frames_pending(local))
> - mod_timer(&local->dynamic_ps_timer, jiffies +
> - msecs_to_jiffies(
> - local->hw.conf.dynamic_ps_timeout));
> - else {
> - ieee80211_send_nullfunc(local, sdata, 1);
> - /* Flush to get the tx status of nullfunc frame */
> - drv_flush(local, false);
> - }
> + ieee80211_send_nullfunc(local, sdata, 1);
> +
> + /* Flush to get the tx status of nullfunc frame */
> + drv_flush(local, false);
> }
>
> if (!((local->hw.flags & IEEE80211_HW_REPORTS_TX_ACK_STATUS) &&
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
