Search Linux Wireless

Re: [PATCH v2] ath5k: free sc->ah in ath5k_deinit_softc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/17/2011 04:41 PM, John W. Linville wrote:
Nothing else is freeing it, and this mirrors the error handling patch
already in ath5k_init_softc.

You mean path, of course.

  	ath5k_hw_deinit(sc->ah);
+	kfree(sc->ah);
  	free_irq(sc->irq, sc);

Looks good to me.

While at that, ath_ahb_remove() misses ieee80211_free_hw(), which is present in the error handling path in ath_ahb_probe(). I have no AHB devices to test. Anyone wants to make a (tested) patch?

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux