Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Tue, 14 Jun 2011 01:34:28 +0300, Kalle Valo wrote: > >> In this patchset I first fix some issues I found from the drivers, >> then create mac80211-compat.h to make the transition as smooth as >> possible and then start changing mac80211 itself. > > FWIW, I don't mind the rename, but I don't like the compat.h thing. > The transition won't be smoothed by this, it just means the transition > will drag out as things conflict etc. My plan was that I will finish the transition and remove mac80211-compat.h before the next merge window. That way the file would not be in any of the official releases. > If we want to rename, we'll need to bite the bullet eventually > anyway. What do you suggest here? So that we should rename everything (both mac80211 and 19 drivers) in one go? If we do that, we would have to do everything in one patch to not break bisect, and it would be huge. With mac80211-compat.h it's possible to break down the patches into small pieces. This makes it easier to create the patches and, most importantly, review them. I'm willing to work on that huge patch if we so decide, but I'm not sure if that's the correct way. Ah, while writing this I realised that I could instead rename symbols in mac80211.h one at a time and that way the patches would be smaller. Did you mean that? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
