Hi Pavel On Wed, Jun 15, 2011 at 06:02:52PM -0400, Pavel Roskin wrote: > WARN_ON is not enough, as we cannot return a valid index, and the > callers will use whatever we return, causing a cascade of oopses and > eventually a panic. We have fedora bug (https://bugzilla.redhat.com/show_bug.cgi?id=702627) where only that warning is generated, and system works further (at least bug reporter did not mention about it's hang). When moving to BUG(), system from user perspective will simply hang, what is much worse. I think, we should rather fix callers to be prepared and recover itself when rate_lowest_index fail. Of course fixing real bug(s) that cause rate index is not found would be best. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
