Dan Carpenter <error27@xxxxxxxxx> writes: >> >> + if (*buf == NULL) { >> >> + if ((A_REQUEST_FIRMWARE(&fw_entry, filename, ((struct device *)ar->osDevInfo.pOSDevice))) != 0) >> >> + { >> > ^ >> > >> > This is on the wrong line. >> >> I'll answer this and all the other style comments in one go: >> >> All the style issues are from the original code. I want to separate >> functional and cleanup patches so I didn't do any cleanup in this >> patch. But as we are doing the cleanup in a different tree anyway I >> didn't see the point of sending a separate cleanup patch. >> > > No. That was in a section of code which was added. There wasn't > a "buf" variable in the original code. You obviously know how it's > supposed to look because you did it correctly on the line before. Oh, you are right. Sorry about that, I'll fix that in v2. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html