On Fri, Jun 10, 2011 at 12:00 PM, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > On Fri, Jun 10, 2011 at 10:45:52AM +0300, Eliad Peller wrote: >> When suspending, __ieee80211_suspend() calls ieee80211_scan_cancel(), >> which will only cancel sw scan. In order to cancel hw scan, the >> low-level driver has to cancel it in the suspend() callback. however, >> this is too late, as a new scan_work will be enqueued (while the driver >> is going into suspend). >> >> Add a new cancel_hw_scan() callback, asking the driver to cancel an >> active hw scan, and call it in ieee80211_scan_cancel(). > > Looks reasonable, but could you also update a comments? > >> + /* >> + * The scan is canceled, but stop work from being pending. > > Also this one is not valid and should be removed. > sure. i'll update the comments. thanks for the review. Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
