On Mon, Jun 06, 2011 at 04:02:49PM +0300, Kalle Valo wrote: > Ido Yariv <ido@xxxxxxxxxx> writes: > > A sysfs binary file named "fwlog" was added to support this feature, > > letting a monitor process read the FW messages. The log is transferred > > from the FW only when available, so the reading process might block. > > Using a sysfs file sounds ugly, isn't there a better way to do this? > For example, does ftrace&co provide anything which wireless drivers > could use? A sysfs entry is indeed sub-optimal. However, we had two requirements for this feature: 1. Retrieving logs should be simple and require no non-standard usermode applications. 2. The on-demand mode could be used on production platforms. ftrace/debugfs/etc. might not be enabled on such systems. For now, we chose to stick with a single sysfs entry, as it accomplishes the above. I agree it looks a bit odd though. Ido. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
