2011/6/6 Hauke Mehrtens <hauke@xxxxxxxxxx>: > +/* driver_mips.c */ > +extern unsigned int bcma_core_mips_irq(struct bcma_device *dev); Does it compile without CONFIG_BCMA_DRIVER_MIPS? > +/* Get the MIPS IRQ assignment for a specified device. > + * If unassigned, 0 is returned. > + * If disabled, 5 is returned. > + * If not supported, 6 is returned. > + */ Does it ever return 6? > +unsigned int bcma_core_mips_irq(struct bcma_device *dev) > +{ > + Â Â Â struct bcma_device *mdev = dev->bus->drv_mips.core; > + Â Â Â u32 irqflag; > + Â Â Â unsigned int irq; > + > + Â Â Â irqflag = bcma_core_mips_irqflag(dev); > + > + Â Â Â for (irq = 1; irq <= 4; irq++) > + Â Â Â Â Â Â Â if (bcma_read32(mdev, BCMA_MIPS_MIPS74K_INTMASK(irq)) & (1 << irqflag)) > + Â Â Â Â Â Â Â Â Â Â Â break; Use scripts/checkpatch*. Braces around "for" and split line to match 80 chars width. Why don't you just use "return irq;" instead of break? > + > + Â Â Â if (irq == 5) > + Â Â Â Â Â Â Â irq = 0; > + > + Â Â Â return irq; You can just make it "return 0;" after changing break to return. > + Â Â Â Â Â Â Â Â Â Â Â for (i = 0; i < bus->nr_cores; i++) > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if ((1 << bcma_core_mips_irqflag(&bus->cores[i])) == oldirqflag) { > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â bcma_core_mips_set_irq(&bus->cores[i], 0); > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â break; > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â } Braces for "for". > + Â Â Â pr_info("after irq reconfiguration\n"); Make first letter uppercase. I'm not English expert, but doesn't something like "IRQ reconfiguration done" sound better? -- RafaÅ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html