W dniu 2 czerwca 2011 13:11 uÅytkownik RafaÅ MiÅecki <zajec5@xxxxxxxxx> napisaÅ:
>
> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
> ---
> Abstracting bus by b43_bus_dev works fine, but there are few places
> where we calls SSB functions in uniq way. That calls happen only once
> in the whole code and so there is not much sense in putting them in
> bus abstraction.
>
> In this situation I have decided to use simple switches. It does not
> make code look lovely, but I do not have any better idea. If anyone
> have - comments are really welcome.
This final code would need to be something like:
switch (dev->dev->bus_type) {
#ifdef CONFIG_B43_BCMA
case B43_BUS_BCMA:
dma->translation = bcma_dma_translation(dev->dev->bdev);
break;
#endif
#ifdef CONFIG_B43_SSB
case B43_BUS_SSB:
dma->translation = ssb_dma_translation(dev->dev->sdev);
break;
#endif
}
So something nicer would be welcome. But what? :| Putting this in
bus.c? Even if that are once-callers?
--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
