On Tue, May 31, 2011 at 08:35:17AM +0200, Johannes Berg wrote: > On Fri, 2011-05-20 at 17:52 +0530, Rajkumar Manoharan wrote: > > Stop tx queues before updating rate control to ensure > > proper rate selection. Otherwise packets can be transmitted > > in 40 Mhz whereas hw is configured in HT20. > > Looks like I completely missed this since you hid it in an ath9k > patchset. DON'T DO THAT. > > Anyway, John, please revert. This is completely useless. Not only is > abusing the CSA stop reason a show-stopper, the whole patch is also just > not right, it seems like a workaround around a rate control algorithm > that isn't able to do an atomic HT change by itself. Also, it won't even > do what you want, there may be packets being processed concurrently > while stopping the queue -- calling stop_queues() is no guarantee that > no packet will be processed afterwards. Rajkumar, do you have an alternative fix to propose? -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html