Hello Jonas,
Checking for CONFIG_BCM47XX instead of __mips__ would be a bit cleaner and less broad. Although the bcm47x6s are not supported by BCM47XX yet, when the support gets added they will be caught by this without affecting other mips platforms. Perhaps a clean solution would be to introduce a quirk option/value in the pci_bus or pci_dev the driver can use to decide at runtime whether it needs this workaround or not. This would also allow other drivers to check for it if they are also affected by it (even if the probability of this is rather low - at least I haven't seen a bcm47x6 yet with anything other than a broadcom wifi connected to its pcie ;-).
Further mips cleanup is in the pipeline, your suggestion is certainly a good one. A similar suggestion has been made by GregKH in the past.
However, the focus of the patch set is on code cleanup. So my intention is to rewrite code to make it cleaner, without changing existing behavior.
Your (and Gregs) suggestion have been noted down and will get a follow-up in the future.
Thanks for the feedback, Roland. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
