On Tue, 2011-05-31 at 12:11 +0300, Eliad Peller wrote: > On Tue, May 31, 2011 at 11:35 AM, Luciano Coelho <coelho@xxxxxx> wrote: > > On Tue, 2011-05-31 at 10:51 +0300, Shahar Levi wrote: > >> The Low Power DRPw (LPD) mode contains several optimizations > >> that designed to reduce the solution's consumption. The > >> purpose is to save current consumption in RX and Listen mode. > >> > >> LPD setting apply only for wl127x AP mode (not wl128x) > >> > >> Signed-off-by: Shahar Levi <shahar_levi@xxxxxx> > >> --- > > > > [...] > > > > > > I still think this is not the right way to do it. It doesn't make sense > > to have it in the configuration parameters. If you want to make it > > configurable, it should be in the NVS file and the driver should clear > > it when not in AP mode (and whoever generates the NVS needs to make sure > > it's never set for wl128x). > > > please don't use the "blacklist" approach. it always gets broken at some point. I totally agree. > > The other solution is to always set this flag when in wl127x in AP-mode, > > in which case it doesn't need to be configurable at all. That would be > > the simplest solution and you could even use a quirk if it makes it > > easier. > > > sounds much better. Yes, and now we got confirmation that this is really the case. It should always be set for wl127x in AP-mode and not be set for anything else. This is a clear case, not a configurable value. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
