On Thu, May 26, 2011 at 7:50 AM, Guy, Wey-Yi <wey-yi.w.guy@xxxxxxxxx> wrote:
> On Thu, 2011-05-26 at 08:14 -0700, Stanislaw Gruszka wrote:
>> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c b/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c
>> index b12c72d..23fa93d 100644
>> --- a/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c
>> +++ b/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c
>> @@ -163,17 +163,9 @@ static void iwlagn_tx_cmd_protection(struct iwl_priv *priv,
>> __le16 fc, __le32 *tx_flags)
>> {
>> if (info->control.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS ||
>> - info->control.rates[0].flags & IEEE80211_TX_RC_USE_CTS_PROTECT) {
>> + info->control.rates[0].flags & IEEE80211_TX_RC_USE_CTS_PROTECT ||
>> + info->flags & IEEE80211_TX_CTL_AMPDU)
>> *tx_flags |= TX_CMD_FLG_PROT_REQUIRE_MSK;
>> - return;
>> - }
>> -
>> - if (priv->cfg->ht_params &&
>> - priv->cfg->ht_params->use_rts_for_aggregation &&
>> - info->flags & IEEE80211_TX_CTL_AMPDU) {
>> - *tx_flags |= TX_CMD_FLG_PROT_REQUIRE_MSK;
>> - return;
>> - }
>> }
Shouldn't there be a new "use_cts_for_aggregation" flag and one that
dominates (looks like use_rts in your setup), rather than this? I'm
still a bit confused as to why CTS-to-self should help (as opposed to
masking some other bug).
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
