On Sun, May 22, 2011 at 8:30 PM, Luciano Coelho <coelho@xxxxxx> wrote:
> On Sun, 2011-05-22 at 15:37 +0300, Eliad Peller wrote:
>> On Sun, May 22, 2011 at 3:34 PM, Eliad Peller <eliad@xxxxxxxxxx> wrote:
>> > On Sat, May 14, 2011 at 12:26 AM, Felipe Balbi <balbi@xxxxxx> wrote:
>> >> Those have little value. Remove those to make
>> >> the driver less noisy.
>> >>
>> >> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
>> >> ---
>> > [...]
>> >> @@ -287,8 +287,6 @@ static int __devinit wl1271_probe(struct sdio_func *func,
>> >> /* Tell PM core that we don't need the card to be powered now */
>> >> pm_runtime_put_noidle(&func->dev);
>> >>
>> >> - wl1271_notice("initialized");
>> >> -
>> >> return 0;
>> >>
>> >
>> >> static void __exit wl1271_exit(void)
>> >> {
>> >> sdio_unregister_driver(&wl1271_sdio_driver);
>> >> -
>> >> - wl1271_notice("unloaded");
>> >> }
>> >>
>> >
>> > in fact, i find these prints pretty useful.
>> > does changing wl1271_notice to wl1271_debug(DEBUG_MAC80211) will solve
>> > the "nosiness"?
>> > (i use DEBUG_MAC80211 rather than DEBUG_SDIO, as DEBUG_SDIO is really
>> > *very* noisy)
>> >
>> > (i'll send it as a new patch as the original patch was already applied)
>> >
>> > Eliad.
>> >
>>
>> err... s/nosiness/noisiness/
>
> I think these are pretty useless. You can see whether the driver is
> loaded or not by lsmod'ing. You can also use ftrace to get the same
> stuff, if you want to know whether the driver is loaded or not offline.
> Or what is the scenario where you think this is useful?
>
i was thinking about a simple offline log analysis, where it's pretty
useful to know when the wl12xx_sdio was insmod'ed/rmmod'ed.
i haven't tried ftrace yet. i'll give it a look.
anyway, the whole wl12xx driver is full of similar logs that get
called multiple times, so i don't see the real advantage of removing 2
prints that get called only once.
> I'm reworking the whole way our traces are handled, so I don't think
> reintroducing them is a good thing.
ok. so i'll just wait for your rework :)
thanks,
Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
