On 05/22/2011 12:37 AM, Johannes Berg wrote:
On Sat, 2011-05-21 at 22:49 +0200, Arend van Spriel wrote:+/** + * enum - CRC8 constants + * + * @CRC8_INIT_VALUE: Initial CRC8 checksum value + * @CRC8_GOOD_VALUE: Good final CRC8 checksum value + * + * Constants for the crc8() function. Refer to its + * documentation how to use these values. + */ +enum CRC8 { + CRC8_INIT_VALUE = 0xff, + CRC8_GOOD_VALUE = 0x9f +};These seem a little out of place, wouldn't that be specific to how the algorithm is used?
True, a different init value likely results in a different good value. However, the documentation of the crc8() function provides one possible use which makes use of these values. So it is provided as a convenience. Removal is easy of course, but I tend to keep it for those who are content with the proposed usage (not necessarily Broadcom :-D ).
Gr. AvS -- Almost nobody dances sober, unless they happen to be insane. -- H.P. Lovecraft -- -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
