Search Linux Wireless

Re: [PATCH] bcma: pci: implement enabling interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 18 maja 2011 13:31 uÅytkownik Arend van Spriel
<arend@xxxxxxxxxxxx> napisaÅ:
> On 05/18/2011 01:26 PM, RafaÅ MiÅecki wrote:
>>
>> W dniu 18 maja 2011 12:39 uÅytkownik Arend van Spriel
>> <arend@xxxxxxxxxxxx> ÂnapisaÅ:
>>>
>>> On 05/18/2011 12:58 PM, RafaÅ MiÅecki wrote:
>>>>
>>>> Signed-off-by: RafaÅ MiÅecki<zajec5@xxxxxxxxx>
>>>> ---
>>>> Âdrivers/bcma/driver_pci.c | Â 18 ++++++++++++++++++
>>>> Â1 files changed, 18 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/bcma/driver_pci.c b/drivers/bcma/driver_pci.c
>>>> index e757e4e..879fe1d 100644
>>>> --- a/drivers/bcma/driver_pci.c
>>>> +++ b/drivers/bcma/driver_pci.c
>>>> @@ -161,3 +161,21 @@ void bcma_core_pci_init(struct bcma_drv_pci *pc)
>>>> Â{
>>>> Â Â Â Âbcma_pcicore_serdes_workaround(pc);
>>>> Â}
>>>> +
>>>> +int bcma_core_pci_irq_enable(struct bcma_drv_pci *pc, struct
>>>> bcma_device
>>>> *core)
>>>> +{
>>>> + Â Â Â struct pci_dev *pdev = pc->core->bus->host_pci;
>>>> + Â Â Â u32 coremask, tmp;
>>>> + Â Â Â int err;
>>>> +
>>>> + Â Â Â coremask = BIT(core->core_index);
>>>> +
>>>> + Â Â Â err = pci_read_config_dword(pdev, BCMA_PCI_IRQMASK,&tmp);
>>>> + Â Â Â if (err)
>>>> + Â Â Â Â Â Â Â goto out;
>>>> + Â Â Â tmp |= coremask<< Â Â8;
>>>> + Â Â Â err = pci_write_config_dword(pdev, BCMA_PCI_IRQMASK, tmp);
>>>> +
>>>> +out:
>>>> + Â Â Â return err;
>>>> +}
>>>
>>> Hi RafaÅ,
>>>
>>> Do you intend to have a disable as well?
>>
>> Sure. I just didn't test disabling function yet, that's why I didn't
>> publish it.
>
> Thanks,
>
> I was just wondering whether there would be a yang for this yin ;-)

Actually, we could use the same function to enable and disable
interrupts. Only one additional argument and one condition is needed.

John: can you drop this patch? In case one function will not be an
option, I'll just resend it.

-- 
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux