Search Linux Wireless

Re: [PATCH 04/32] staging: brcm80211: got rid of #ifdef __mips__ sections in hnddma.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 14, 2011 at 12:16:31PM +0200, Jonas Gorski wrote:
> On 13 May 2011 11:59, Arend van Spriel <arend@xxxxxxxxxxxx> wrote:
> > From: Roland Vossen <rvossen@xxxxxxxxxxxx>
> >
> > Code cleanup. Broadcom MIPS chips in big endian mode have a memory window
> > in which sdram contents is byte swapped. Code in hnddmac.c makes use of
> > this window. Reworked code so the #ifdef __mips__ is moved from .c to
> > .h file.
> 
> Shouldn't this be guarded with e.g. CONFIG_BCM63XX instead of
> __mips__? Not every big endian mips is a broadcom ;-). I don't know if
> there are further Broadcom ones, the only other I know is bcm47xx and
> that one is little endian.

Good point, now dropped.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux