Search Linux Wireless

RE: [PATCH] cfg80211: make stripping of 802.11 header optional from AMSDU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

> > Currently the devices that have already stripped IEEE 802.11
> > header from the AMSDU SKB can not use ieee80211_amsdu_to_8023s
> > routine. This patch enhances ieee80211_amsdu_to_8023s() API by
> > changing mandatory removing of IEEE 802.11 header from AMSDU
> > to optional.
> 
> Nice.
> 
> > @@ -2173,10 +2173,13 @@ int ieee80211_data_from_8023(struct sk_buff *skb, const u8 *addr,
> >   * @addr: The device MAC address.
> >   * @iftype: The device interface type.
> >   * @extra_headroom: The hardware extra headroom for SKBs in the @list.
> > + * @stripped_80211_header: Set it true if SKB is without IEEE 802.11
> > + *	header.
> 
> I think I'd prefer this be the other way around though, like
> "has_80211_header" (or so), that seems more natural here and in the
> code? Not that it matters much.

Thanks for your suggestion. I will resend the updated patch.

Regards,
Bing

ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux