On Fri, May 13, 2011 at 03:33:03PM +0200, RafaÅ MiÅecki wrote:
> 2011/5/13 John W. Linville <linville@xxxxxxxxxxxxx>:
> > drivers/ssb/main.c:1336: error: 'SSB_PCICORE_BCAST_ADDR' undeclared (first use in this function)
> > drivers/ssb/main.c:1337: error: 'SSB_PCICORE_BCAST_DATA' undeclared (first use in this function)
> > drivers/ssb/main.c:1349: error: 'struct ssb_pcicore' has no member named 'dev'
> >
> > Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> > ---
> > Âdrivers/ssb/main.c | Â Â2 ++
> > Â1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> > index ee2937c..a53fc4d 100644
> > --- a/drivers/ssb/main.c
> > +++ b/drivers/ssb/main.c
> > @@ -1332,6 +1332,7 @@ EXPORT_SYMBOL(ssb_bus_powerup);
> > Âstatic void ssb_broadcast_value(struct ssb_device *dev,
> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âu32 address, u32 data)
> > Â{
> > +#ifdef CONFIG_SSB_DRIVER_PCICORE
> > Â Â Â Â/* This is used for both, PCI and ChipCommon core, so be careful. */
> > Â Â Â ÂBUILD_BUG_ON(SSB_PCICORE_BCAST_ADDR != SSB_CHIPCO_BCAST_ADDR);
> > Â Â Â ÂBUILD_BUG_ON(SSB_PCICORE_BCAST_DATA != SSB_CHIPCO_BCAST_DATA);
> > @@ -1340,6 +1341,7 @@ static void ssb_broadcast_value(struct ssb_device *dev,
> > Â Â Â Âssb_read32(dev, SSB_PCICORE_BCAST_ADDR); /* flush */
> > Â Â Â Âssb_write32(dev, SSB_PCICORE_BCAST_DATA, data);
> > Â Â Â Âssb_read32(dev, SSB_PCICORE_BCAST_DATA); /* flush */
> > +#endif
> > Â}
> >
> > Âvoid ssb_commit_settings(struct ssb_bus *bus)
>
> From *quick* review I think it's wrong. WIth this patch we don't do
> commiting without PCI driver. This is still possible, we just need to
> use ChipCommon for commiting.
I'm happy for a better patch, but since the build is failing as-is...
--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
