Search Linux Wireless

Re: mesh RCU issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-05-12 at 15:26 -0700, Javier Cardona wrote:

> > And indeed I don't see a del_timer_sync() when the mesh path is freed.
> 
> Isn't the call to del_timer_sync() you are looking for in
> mesh_path_node_reclaim() ?

Hmm, indeed, but it looks like mesh_path_node_free() also frees a node,
no? I'd only found the latter function freeing it and got worried.

> > But this is _clearly_ totally bogus. Somebody please fix ASAP.
> 
> I'll run sparse and see if I see other rcu warnings that I can fix.

Thanks. I think most of the use is probably OK or "just" missing
rcu_dereference() wrappers. The global mesh_paths and mpp_paths
variables should also be __rcu I think, but that caused so many warnings
that I gave up for now, and I didn't quite understand what was going on.

You'll want to apply
http://johannes.sipsolutions.net/patches/kernel/all/LATEST/NNN-mac80211-rcu-annotations.patch to get rid of all the other spurious RCU warnings with CONFIG_SPARSE_RCU.

Thanks,
Johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux