On Wed, 2011-05-11 at 17:21 -0700, Rhyland Klein wrote: > +enum rfkill_gpio_clk_state { > + UNSPECIFIED = 0, > + PWR_ENABLED, > + PWR_DISABLED Are you sure starting out with UNSPECIFIED works? Then you'll always change, but if the clock was enabled already you still enable it on the first set_block() from rfkill, which still has the refcount problem, no? It seems to me that the original state has to be passed in from the platform? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html