On Wednesday 11 May 2011 18:17:51 Larry Finger wrote: > The PCI routine of this driver is allocating receive buffers of order 2, > which causes an unnecessary fragmentation of memory. To make matters > worse, there are locations that fail to check for allocation failures, > or return success when the allocation actually failed. Kernel panics > result. > > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Stable <stable@xxxxxxxxxxxxxxx> [2.6.37 and 2.6.38] > --- > > John, > > This is 2.6.39 material. I hope we make the cutoff. > > Larry > --- > > Index: wireless-testing-new/drivers/net/wireless/rtlwifi/pci.c > =================================================================== > --- wireless-testing-new.orig/drivers/net/wireless/rtlwifi/pci.c > +++ wireless-testing-new/drivers/net/wireless/rtlwifi/pci.c > @@ -996,7 +998,7 @@ static void _rtl_pci_init_trx_var(struct > */ > rtlpci->txringcount[BE_QUEUE] = RT_TXDESC_NUM_BE_QUEUE; > > - rtlpci->rxbuffersize = 9100; /*2048/1024; */ > + rtlpci->rxbuffersize = 4096; > rtlpci->rxringcount = RTL_PCI_MAX_RX_COUNT; /*64; */ > } > Are you sure this change won't break 8k AMSDU rx? [or is there some magic that disables disable_amsdu_8k for pci devices?] Regards, Chr -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
