On Sat, 2011-05-07 at 22:40 +0200, RafaÅ MiÅecki wrote:
> Michael, I can see code for ignoring dangling cores in both: ssb and b43.
>
> In ssb it's quite common, we have:
> 1) we_support_multiple_80211_cores for 80211
> 2) inline checks in ssb_bus_scan for PCI(E)
> 3) inline check in ssb_bus_scan for ETHERNET
>
> However there is also check in b43 at the beginning of b43_one_core_attach:
> if (!pdev ||
> ((pdev->device != 0x4321) &&
> (pdev->device != 0x4313) && (pdev->device != 0x431A))) {
> b43dbg(wl, "Ignoring unconnected 802.11 core\n");
> return -ENODEV;
> }
>
> Should I move this check into ssb?
Well, I'm not sure. _Neither_ place looks fine. It's a dirty workaround
for broken hardware.
If you really want to touch this mess, then yes. Move it into ssb.
--
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
