On Fri, May 6, 2011 at 3:26 PM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: > Last time this driver came up the answer was that the userspace was > proprietary and this was in fact part of a mixed user/kernel driver which > seemed to raise all sorts of interesting questions. > > This was NAKked before for that reason so why the resubmit. Kernel policy > is clear enough ? I was not aware such a patch was even submitted before.. >> + * You need a userspace application to cooperate with this driver. It and >> + * more information about this driver can be obtained here: >> + * >> + * http://wireless.kernel.org/en/users/Drivers/ar5120 > > Which says: > > Userspace application > > This driver requires a userspace application which will interact with the > driver via ioctl. More information on this to be posted later. > > So NAK Umm, yeah, also unaware there was no userspace app which was open that was going to be provided, sorry about that, I'll check with the team... > Let's see an open userspace and then this driver can be submitted > > + Â Â Â Â Â Â Â time = > Âwait_event_interruptible_timeout(ar1520_data->wait_irq, > + > Âar1520_data->irq_rx, + > Âmsecs_to_jiffies(3142)); > > Why 3142 ? Really arbitrary as pi is, this didn't have a timeout before so I just added this for now. Was hoping Roman or Joonas can better estimate a better value here. > Come to think of it why not fixes the races while you are it. Sure. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
