On Wed, 2011-05-04 at 14:39 -0500, Dan Williams wrote: > On Mon, 2011-05-02 at 16:49 -0700, Joe Perches wrote: > > Use the standard pr_<level> functions eases grep a bit. > > Added a few missing terminating newlines to messages. > > Coalesced long formats. > Is there any reason to not put the pr_fmt() definition into 'defs.h' > instead of C&P at the top of every file? I don't really care either way > but that seems cleaner since almost all the libertas files are going to > use logging. It has to be before any #include <linux/kernel.h> or any other #include that uses it. At some point, all of the uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt should be removed as I intend to have that or an equivalent become the default. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
