Hi John,
> Subject: [PATCH] mwifiex: fix copy-n-paste 'thinko' for tsf_val
>
> CC [M] drivers/net/wireless/mwifiex/join.o
> drivers/net/wireless/mwifiex/join.c: In function âmwifiex_cmd_802_11_associateâ:
> drivers/net/wireless/mwifiex/join.c:119:8: warning: âtsf_valâ may be used uninitialized in this
> function
> drivers/net/wireless/mwifiex/join.c:103:12: note: âtsf_valâ was declared here
Thanks for spotting this error. I will update my gcc as my current version 4.4.1 20090725 cannot find this warning.
>
> Looks like a copy-n-paste error, identical lines are a few lines below
> the ones removed, with an actual memcpy to tsf_val in between...
It's not a copy-n-paste error, but you hit a bug here.
Actually two sets of tsf_val are copied to the buffer. I missed the initialization code for the first tsf_val.
I will send a patch to fix it.
Thanks,
Bing
ÿô.nlj·Ÿ®‰†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf
