On Fri, Apr 22, 2011 at 09:31:43PM +0200, Javier Lopez wrote:
> This is an updated patch that solve the issues found in the previous
> patch, it adds frame exchange capabilities with userspace to
> mac80211_hwsim driver. Allowing user space applications to decide if a
> frame should be dropped or not.
>
> Frame exchange between kernel and userspace is done through a generic
> netlink communication protocol, a new family called HWSIM is proposed
> in order to communicate with userspace applications. This family
> +static struct genl_family hwsim_genl_family = {
> + .id = GENL_ID_GENERATE,
> + .hdrsize = 0,
> + .name = "HWSIM",
> + .version = VERSION_NR,
> + .maxattr = HWSIM_ATTR_MAX,
> +};
I don't have any big objections to this patch. But I think that
"HWSIM" is not a very good name. Most/all of the other genl_family
definitions seem to use a name specific to their function. While
"HWSIM" is somewhat descriptive, it seems prone to confusion. I would
prefer to see a name like "mac80211_hwsim".
John
P.S. Sorry to "bikeshed" this...
--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
