Search Linux Wireless

Re: [PATCH] mac80211: report MIC failure for truncated packets in AP mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2011 at 10:27 PM, Arik Nemtsov <arik@xxxxxxxxxx> wrote:
> MIC failure notifications for packets too short to contain a key index
> are currently ignored in AP-mode. Fix the check to only ignore packets
> with an existing non-zero key index.
>
> The wl12xx chip always truncates packets with a failed MIC and requires
> this change to operate correctly in AP-mode.
>
> No such check is made in STA mode. Therefore its relatively safe to assume
> there's no other HW that relies on the current code to avoid spurious
> MIC failures with correct yet truncated packets.
>
> Signed-off-by: Arik Nemtsov <arik@xxxxxxxxxx>
> ---
>  net/mac80211/rx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> index a864890..875fc3c 100644
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -2391,7 +2391,7 @@ static void ieee80211_rx_michael_mic_report(struct ieee80211_hdr *hdr,
>        if (!ieee80211_has_protected(hdr->frame_control))
>                return;
>
> -       if (rx->sdata->vif.type == NL80211_IFTYPE_AP && keyidx) {
> +       if (rx->sdata->vif.type == NL80211_IFTYPE_AP && keyidx > 0) {
>                /*
>                 * APs with pairwise keys should never receive Michael MIC
>                 * errors for non-zero keyidx because these are reserved for
> --
wait! Since you seem able to trigger MIC events frequently, could you
please test if the following patch:

<http://www.spinics.net/lists/linux-wireless/msg67571.html>

<a little more info:http://www.spinics.net/lists/linux-wireless/msg67461.html>

would help in your case as well?

Regards,
     Christian
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux