Search Linux Wireless

Re: [PATCH 1/1 RFC] mac80211: add ratio to led blinking trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2011-04-24 at 11:38 -0700, Johannes Berg wrote:
> On Sun, 2011-04-24 at 10:15 -0700, Wey-Yi Guy wrote:
> > The current led blink trigger implementaion assume on/off time are equal,
> > it works but not have any flexbile for different blink pattern.
> > 
> > Add "ratio" parameter in the trigger table and give driver more control
> > on how the on/off blink time behavior should be.
> 
> I considered this when writing the original code, but then decided that
> nobody needed to have unequal on/off times. Why would we need it now?
> (FWIW, blink = 0 is always on already, no?)
> 
But from what I read for iwlwifi, to turn LED_SOLID_ON, on = 11, off =
0. Did I read it wrong.

Yes, I agree as today, "on" == "off", just thinking we should make more
flexible.

Wey



--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux