On Tue, 2011-04-05 at 19:13 +0300, Eliad Peller wrote: > ieee80211_reconfig() sets most of the "changed" flags regardless > of the actual change (e.g. BSS_CHANGED_ASSOC will be set even if > the interface is still not associated). in this case the driver > will issue some unneeded commands. > > Since the driver relies solely on the BSS_CHANGED_ASSOC flag, > without checking if there was an actual change, it will end up > issuing unjoin() and dummy_join() commands, although it was > never associated and should just remain idle. > > Avoid it by checking the actual state change, in addition to the > "changed" flag. > > (there seem to be more redundant configuration commands being > issued, but they shouldn't harm) > > Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> > --- Indeed, I have seen similar assumptions in the driver that caused problems. Thanks for the fix. Applied. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
