On Mon, Apr 18, 2011 at 09:44:09AM -0700, Wey-Yi Guy wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > @@ -394,7 +394,9 @@ int iwl_hw_txq_attach_buf_to_tfd(struct iwl_priv *priv, > return -EINVAL; > } > > - BUG_ON(addr & ~DMA_BIT_MASK(36)); > + if (WARN_ON(addr & ~DMA_BIT_MASK(36))) > + return -EINVAL; Seems useless. > @@ -169,10 +171,12 @@ int iwl_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd) > int cmd_idx; > int ret; > > - lockdep_assert_held(&priv->mutex); I think better keep it. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
