Search Linux Wireless

Re: [PATCH 1/2] ath9k: fix powersave frame filtering/buffering in AP mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-04-18 1:10 PM, Sujith wrote:
Felix Fietkau wrote:
 The driver calls ieee80211_sta_set_tim on STA_NOTIFY_SLEEP whenever it
 still has some buffered frames that it intends to keep until the client
 wakes up again (i.e. frames that will not be returned to mac80211 as
 filtered).

Why should ieee80211_sta_set_tim() be called from complete_aggr() ?
I should probably add an extra check that tests for tid->buf_q being empty - and some comments. This handles a race condition that occurs if an A-MPDU completes (with some pending frames) after the station entered PS and ieee80211_sta_set_tim was not called because the buffer queue was empty.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux