On Fri, Apr 15, 2011 at 12:10:03PM +0530, Sujith wrote:
> Rajkumar Manoharan wrote:
> > + priv->debug.debugfs_phy = debugfs_create_dir("ath9k_htc",
> > + priv->hw->wiphy->debugfsdir);
>
> KBUILD_MODNAME can be used.
>
> > + debugfs_create_file("debug", S_IRUSR, priv->debug.debugfs_phy,
> > + priv, &fops_debug);
> >
>
> S_IWUSR.
>
> > static void ath9k_deinit_priv(struct ath9k_htc_priv *priv)
> > {
> > - ath9k_htc_exit_debug(priv->ah);
> > ath9k_hw_deinit(priv->ah);
> > kfree(priv->ah);
> > priv->ah = NULL;
> > @@ -150,6 +149,10 @@ static void ath9k_deinit_device(struct ath9k_htc_priv *priv)
> > {
> > struct ieee80211_hw *hw = priv->hw;
> >
> > + if (priv->debug.debugfs_phy) {
> > + debugfs_remove_recursive(priv->debug.debugfs_phy);
> > + priv->debug.debugfs_phy = NULL;
> > + }
>
> It would be consistent to have this chunk of code in ath9k_htc_exit_debug().
>
I think mac80211 handles debugfs_remove_recursive. isn't it?
If so, Shall I remove it?
--
Rajkumar
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
