Search Linux Wireless

Re: [PATCH 2/2] mwl8k: setting IEEE80211_HW_CRYPTO_ENABLED for AP mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yogesh Ashok Powar <yogeshp@xxxxxxxxxxx> writes:

> For AP mode, driver sets IEEE80211_HW_CRYPTO_ENABLED hardware flag to avoid
> mac80211 reserving tail room space for crypto suite.

A small style issue:

> +	/* This is needed to avoid tailroom calculations */
> +	hw->flags |= priv->ap_fw ? IEEE80211_HW_CRYPTO_ENABLED : 0;

Why not just:

if (priv->ap_fw)
   hw->flags |= IEEE80211_HW_CRYPTO_ENABLED

A lot easier to read.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux