[gah, this gmail account has html formatting on by default. repost in plain text] On Mon, Apr 11, 2011 at 7:53 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Mon, 2011-04-11 at 20:15 +0530, Anantha Idapalapati wrote: > > Initially it was written specific to BCM4329. But because of the > > reason most of the BT chips have similar switch on/off sequence, this > > driver is made generic. If there is any specific changes required for > > a particular platform, this driver can be taken as reference. > > Well, so, it still has bcm4329 all over the code, so you should get rid > of that and just call it rfkill_gpio or something. Also, if it's all > this generic, then how about you make an rfkill GPIO driver that works > like the rfkill regulator driver we recently got? Anantha, This doesn't seem to be the same version of the driver as the last one you uploaded to the Chromium OS code review system, which had all the brcm4329 references renamed and moved out of the driver. Any reason you wouldn't start out with the cleanest version before you submit? The version I'm referring to is at: http://codereview.chromium.org/6295009/ -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
