Search Linux Wireless

Re: [PATCH 1/7] ath5k: optimize tx descriptor setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felix Fietkau <nbd@xxxxxxxxxxx> writes:

> Use local variables to reduce the number of load/store operations on uncached
> memory.

A comment in the code would be nice as well. Otherwise later on
someone decides to "optimise" and remove the local variables :)

>  	/* Clear descriptor */
> -	memset(&desc->ud.ds_tx5212, 0, sizeof(struct ath5k_hw_5212_tx_desc));
> +	memset(&desc->ud.ds_tx5212.tx_stat, 0,
> +	       sizeof(desc->ud.ds_tx5212.tx_stat));

Is this an unrelated change? Or maybe I just missed something.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux