On Fri, Apr 08, 2011 at 02:38:27PM +0530, Nishant Sarmukadam wrote: > We do not need to enable all the interrupts in mwl8k_probe_hw. > We need to enable only MWL8K_A2H_INT_OPC_DONE interrupt for sending > commands to the firmware. Keep the other interrupts masked in > mwl8k_probe_hw. This part of the description matches the patch. But.. > Also, in mwl8k_start, where we expect other interrupts, > enable only those interrupts we are interested in. ..this comment does not match the code. > /* Enable interrupts */ > iowrite32(MWL8K_A2H_EVENTS, priv->regs + MWL8K_HIU_A2H_INTERRUPT_MASK); > + iowrite32(MWL8K_A2H_EVENTS, > + priv->regs + MWL8K_HIU_A2H_INTERRUPT_STATUS_MASK); This writes to the status register. Why does it do that? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
