On Wed, Apr 6, 2011 at 6:31 AM, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote:
> On Mon, Apr 04, 2011 at 06:15:31PM -0700, Thomas Pedersen wrote:
>> - /* first allocate the new vendor information element */
>> + /* allocate information elements */
>> new_ie = NULL;
>> - old_ie = ifmsh->vendor_ie;
>> + old_ie = ifmsh->ie;
>>
>> - ifmsh->vendor_ie_len = setup->vendor_ie_len;
>> - if (setup->vendor_ie_len) {
>> - new_ie = kmemdup(setup->vendor_ie, setup->vendor_ie_len,
>> + ifmsh->ie_len = setup->ie_len;
>> + if (setup->ie_len) {
>> + new_ie = kmemdup(setup->ie, setup->ie_len,
>> GFP_KERNEL);
>> if (!new_ie)
>> return -ENOMEM;
>
> No idea if this is a problem, but in !new_ie case, after function
> exit ifmsh->ie_len will not match ifmsh->ie .
>
Yes you are right, good catch. This will be fixed in next resubmission.
> Stanislaw
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
