On Wed, 06 Apr 2011 11:29:38 +0200
Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2011-04-06 at 11:21 +0200, Antonio Ospite wrote:
>
> > + if (regulator_is_enabled(vcc)) {
> > + dev_dbg(&pdev->dev, "Regulator already enabled\n");
> > + rfkill_data->reg_enabled = 1;
> > + }
> > + rfkill_init_sw_state(rf_kill, !rfkill_data->reg_enabled);
> > +
> > + ret = rfkill_register(rf_kill);
>
> We recently had a thread about how rfkill_init_sw_state() isn't quite
> working the right way. Also, it is indented to be used for devices that
> keep their state over resume. I think you should remove it here and rely
> on rfkill to sync you after registration.
>
> Cf. the long thread here:
> http://thread.gmane.org/gmane.linux.acpi.devel/49577
>
Ok, but I still need to replace that call with a rfkill_set_sw_state()
to expose the initial status of the regulator to the rfkill system,
right?
> Other than that, no comments from me from an rfkill POV.
>
> johannes
>
Thanks I am waiting a couple of days before sending a v2.
Regards,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
Attachment:
pgpeQln7oOVel.pgp
Description: PGP signature
