Search Linux Wireless

Re: [PATCH] rt2x00: fix cancelling uninitialized work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 4, 2011 at 1:50 PM, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote:
> {rx,tx}done_work's are only initialized for usb devices.
>
> Cc: stable@xxxxxxxxxx
> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>

Acked-by: Ivo van Doorn <IvDoorn@xxxxxxxxx>

> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 9de9dbe..84eb6ad 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1062,8 +1062,10 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
>         * Stop all work.
>         */
>        cancel_work_sync(&rt2x00dev->intf_work);
> -       cancel_work_sync(&rt2x00dev->rxdone_work);
> -       cancel_work_sync(&rt2x00dev->txdone_work);
> +       if (rt2x00_is_usb(rt2x00dev)) {
> +               cancel_work_sync(&rt2x00dev->rxdone_work);
> +               cancel_work_sync(&rt2x00dev->txdone_work);
> +       }
>        destroy_workqueue(rt2x00dev->workqueue);
>
>        /*
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux