Hey, > > In iwlwifi, we just have iwl_send_cmd_sync(), which does all the wait. > > That also has the added benefit that the wait queue doesn't need to be > > dynamically allocated, it can just be on the stack. Also, your dynamic > > allocations for that don't really seem to require GFP_ATOMIC in most > > places, but that's probably the least of the worries here. > > I will study the iwl_send_cmd_sync() implementation. And have mwifiex > use the same way to send commands as iwlwifi driver does. I'm not saying that you need to do that exactly in the same way. It's just that allocating the wait queue dynamically and then passing it across a few functions seems to bloat the code and I also think it's more error prone. Are there any asynchronous commands at all anyway? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
