On Fri, Mar 18, 2011 at 11:03 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 18 Mar 2011 10:41:53 -0700, Luis R. Rodriguez wrote: >>> >>> On Fri, Mar 18, 2011 at 6:50 AM, John W. Linville >>>> >>>> Does anyone even have this hardware? > > I don't think it even exists any more. Can the driver be removed? >> So similarly here we can likely hit a case where we hit the double >> wiphy_unregister() twice and I think we'd oops. My preference is to >> make wiphy_unregister() re-entrant and let us detect when the device >> already was unregistered. Johannes? > > I don't like that, it encourages sloppy driver writing. Seriously, > why is it so hard to properly write the code? > > You can fail during init, or you can properly deregister, and that's > about it, no? That's fine too. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html