Search Linux Wireless

Re: [PATCH] iw: Add send callback with optional debug handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  I have made the test syntax change you recommended and attached the
gzipped 'git format-patch'.

On Thu, Mar 17, 2011 at 2:29 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2011-03-16 at 17:28 -0700, Sean Robinson wrote:
>> libnl supports callbacks for send and recv. ÂThis patch enables callbacks
>> for sent messages and uses the debug callback for the --debug option, as
>> the recv callbacks do.
>
> I can't apply this, the patch is corrupted.
>
>> Â Â Â cb = nl_cb_alloc(iw_debug ? NL_CB_DEBUG : NL_CB_DEFAULT);
>> - Â Â if (!cb) {
>> + Â Â s_cb = nl_cb_alloc(iw_debug ? NL_CB_DEBUG : NL_CB_DEFAULT);
>> + Â Â if (!(cb && s_cb)) {
>
> I think (!cb || !s_cb) would be easier to read.
>
> johannes
>
>
>



-- 
Sean Robinson
WiFi Radar - http://wifi-radar.berlios.de
Python WiFi - http://pythonwifi.wikispot.org
pymnl - http://pymnl.wikispot.org

Attachment: 0001-Add-send-callbacks-with-optional-debug-handler.patch.gz
Description: GNU Zip compressed data


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux