On Wed, 2011-03-16 at 01:44 -0700, Daniel Halperin wrote: > On Wed, Mar 16, 2011 at 1:21 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Tue, 2011-03-15 at 16:49 -0700, Daniel Halperin wrote: > > > >> x-T-R1-y-R2, > > > >> if (!time_after(jiffies, tid_agg_rx->reorder_time[j] + > >> - HT_RX_REORDER_BUF_TIMEOUT)) > >> + HT_RX_REORDER_BUF_TIMEOUT) && skipped) > > > > Wait, your previous example of xT---R worked fine, but if you say x-T- > > this patch won't work I think? Basically you're saying if we received > > frames 2 and 4 after 3, and 3 times out, we can release 2 through 4. I > > agree, but your code won't do that since skipped starts out at 1 due to > > the first x. Or am I misreading this? > > > > The syntax I used in our private mail was confusing and I tried to > simplify. Here, hyphens are just separators between frames (since R1, > R2 have two-letter identifiers). Does that clear it up? Oh. Right. Still though, what if it is x-R1-T-R2-y-...? This fixes x-T-R1-...-y-..., but shouldn't some release be possible in the other case as well? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
