Hi Daniel, On Tue, 2011-03-15 at 11:25 -0700, Daniel Halperin wrote: > From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > See this thread for more information: > http://comments.gmane.org/gmane.linux.kernel.wireless.general/66236 > > > the window size and frame limit should > > both match the information about the aggregation session, and be limited > > to what we and the peer would like to see. > > > > The bad thing is that we set up the queue when we get > > IEEE80211_AMPDU_TX_START, but we only know the window size when we get > > IEEE80211_AMPDU_TX_OPERATIONAL. However, I think we can change this > > since the first TX to the queue will only happen after _OPERATIONAL. We > > just need to refactor iwlagn_tx_agg_start() into the parts that can > > fail, and the parts that don't. > > From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > Tested-by: Daniel Halperin <dhalperi@xxxxxxxxxxxxxxxxx> > Signed-off-by: Daniel Halperin <dhalperi@xxxxxxxxxxxxxxxxx> > --- > Dan says: ditto from previous patch. > --- > drivers/net/wireless/iwlwifi/iwl-agn-tx.c | 46 +++++++++++++++++++--------- > drivers/net/wireless/iwlwifi/iwl-agn.c | 4 ++ > drivers/net/wireless/iwlwifi/iwl-agn.h | 3 ++ > drivers/net/wireless/iwlwifi/iwl-dev.h | 1 + > 4 files changed, 39 insertions(+), 15 deletions(-) I will prefer let us testing the patch first before push upstream. Wey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html