Search Linux Wireless

Re: [PATCH v2 4/4] ath9k: improve reliability of beacon transmission and stuck beacon handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felix Fietkau wrote:
> diff --git a/drivers/net/wireless/ath/ath9k/mac.c b/drivers/net/wireless/ath/ath9k/mac.c
[...]
> +bool ath9k_hw_stop_dma_queue(struct ath_hw *ah, u32 q)
[...]
> -                               ath_err(common,
> -                                       "Failed to stop TX DMA in 100 msec after killing last frame\n");

Are you concerned about getting rid of this error that
ath9k_hw_stoptxdma used to print? It doesn’t seem like anything else
in the remaining code that uses it (ath_beacon_tasklet and
ath9k_set_beaconing_status) will produce an error.

Based on the message you sent with patch 2/4, “I can no longer trigger
these messages on AR9380, and on AR9280 they become much more rare,”
and the fact that you left the message intact in that patch’s
ath_drain_all_txq, I wonder it’s appropriate to remove the message
from this function.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux