Search Linux Wireless

Re: [PATCH 2/2] wl1251: fix elp_work race condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Grazvydas Ignotas <notasas@xxxxxxxxx> writes:

> While working on PS I've noticed elp_work is kicking rather often, and
> sometimes the chip is put to sleep before 5ms delay expires. This
> seems to happen because by the time wl1251_ps_elp_wakeup is called
> elp_work might still be pending. After wakeup is done, the processing
> may take some time, during which 5ms might expire and elp_work might
> get scheduled. In this case, ss soon as 1st thread finishes work and
> releases the mutex, elp_work will then put the device to sleep without
> 5ms delay. In addition 1st thread will queue additional elp_work
> needlessly.
>
> Fix this by cancelling work in wl1251_ps_elp_wakeup instead.

Thanks for debugging this.

> Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx>

Acked-by: Kalle Valo <kvalo@xxxxxxxxxx>

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux