Grazvydas Ignotas <notasas@xxxxxxxxx> writes: > While working on PS I've noticed elp_work is kicking rather often, and > sometimes the chip is put to sleep before 5ms delay expires. This > seems to happen because by the time wl1251_ps_elp_wakeup is called > elp_work might still be pending. After wakeup is done, the processing > may take some time, during which 5ms might expire and elp_work might > get scheduled. In this case, ss soon as 1st thread finishes work and > releases the mutex, elp_work will then put the device to sleep without > 5ms delay. In addition 1st thread will queue additional elp_work > needlessly. > > Fix this by cancelling work in wl1251_ps_elp_wakeup instead. Thanks for debugging this. > Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx> Acked-by: Kalle Valo <kvalo@xxxxxxxxxx> -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html