On Sun, 2011-03-06 at 16:32 +0200, Shahar Levi wrote: > Reduced bus transactions in Tx & Rx path > > Signed-off-by: Shahar Levi <shahar_levi@xxxxxx> > --- > diff --git a/drivers/net/wireless/wl12xx/rx.c b/drivers/net/wireless/wl12xx/rx.c > index 919b59f..c95ae19 100644 > --- a/drivers/net/wireless/wl12xx/rx.c > +++ b/drivers/net/wireless/wl12xx/rx.c [...] > @@ -204,7 +211,8 @@ void wl1271_rx(struct wl1271 *wl, struct wl1271_fw_common_status *status) > * Write the driver's packet counter to the FW. This is only required > * for older hardware revisions > */ > - if (wl->quirks & WL12XX_QUIRK_END_OF_TRANSACTION) > + if ((wl->chip.id != CHIP_ID_1283_PG20) && > + (wl->quirks & WL12XX_QUIRK_END_OF_TRANSACTION)) > wl1271_write32(wl, RX_DRIVER_COUNTER_ADDRESS, wl->rx_counter); > } The WL12XX_QUIRK_END_OF_TRANSACTION is only enabled for wl127x, so no need to check that it's not wl128x here. > @@ -537,7 +550,8 @@ out_ack: > * Interrupt the firmware with the new packets. This is only > * required for older hardware revisions > */ > - if (wl->quirks & WL12XX_QUIRK_END_OF_TRANSACTION) > + if ((wl->chip.id != CHIP_ID_1283_PG20) && > + (wl->quirks & WL12XX_QUIRK_END_OF_TRANSACTION)) > wl1271_write32(wl, WL1271_HOST_WR_ACCESS, > wl->tx_packets_count); > Same thing here. I'll remove these unnecessary checks. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
