On Sun, 2011-03-06 at 16:32 +0200, Shahar Levi wrote: > - clk |= (wl->ref_clock << 1) << 4; > + if (wl->chip.id == CHIP_ID_1283_PG20) { > + if (is_ref_clk == false) > + clk |= ((wl->tcxo_clock & 0x3) << 1) << 4; > + else > + clk |= ((wl->ref_clock & 0x3) << 1) << 4; > + } else > + clk |= ((wl->ref_clock & 0x3) << 1) << 4; > + > wl1271_write32(wl, DRPW_SCRATCH_START, clk); Can you explain why you changed the wl127x part as well? For wl127x you're essentially changing: clk |= (wl->ref_clock << 1) << 4; to: clk |= ((wl->ref_clock & 0x3) << 1) << 4; This means that CONF_REF_CLK_38_4_M_XTAL will be treated in the same way as CONF_REF_CLK_19_2_E. Is that right? If it is, it must be addressed in a separate patch and not as part of the Quattro series. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html